Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting fix #44521

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Formatting fix #44521

merged 2 commits into from
Nov 23, 2020

Conversation

gonnet
Copy link
Contributor

@gonnet gonnet commented Nov 2, 2020

Formatting fix in documentation of zeros_like in backend.py.

@gonnet
Formatting fix
d75fdc4 
Formatting fix in documentation of `zeros_like` in backend.py.
@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Nov 2, 2020
@google-cla google-cla bot added the cla: yes label Nov 2, 2020
@gbaned gbaned self-assigned this Nov 2, 2020
@gbaned gbaned added the comp:keras Keras related issues label Nov 2, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Nov 2, 2020
@gbaned gbaned self-requested a review November 2, 2020 15:17
fchollet
fchollet requested changes Nov 12, 2020
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR

tensorflow/python/keras/backend.py Outdated Show resolved Hide resolved
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Nov 12, 2020
@gonnet gonnet requested a review from fchollet November 13, 2020 13:08
fchollet
fchollet approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Nov 14, 2020
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Nov 14, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 14, 2020
@gonnet
Copy link
Contributor Author

gonnet commented Nov 16, 2020

Is there any way to re-run failing tests?

@mihaimaruseac
Copy link
Collaborator

Please use testable docstrings instead of inline code blocks. See https://www.tensorflow.org/community/contribute/docs_ref

@gonnet
Copy link
Contributor Author

gonnet commented Nov 17, 2020

Please use testable docstrings instead of inline code blocks. See https://www.tensorflow.org/community/contribute/docs_ref

Now I'm a bit confused... I had done that originally, but @fchollet asked me to use code block formatting instead, since "these lines are not meant to be executed as part of our "doctest" suite".

So should these lines be a doctest or not?

Cheers, Pedro

@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Nov 18, 2020
@mihaimaruseac
Copy link
Collaborator

You are right, my bad

@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 18, 2020
@gonnet
Copy link
Contributor Author

gonnet commented Nov 18, 2020

@mihaimaruseac Since you're here, is there any way to re-run the failing tests? Cheers!

@mihaimaruseac
Copy link
Collaborator

Adding the kokoro label retriggers the tests, but it has to be done by a googler.

Right now the PR is waiting import into Google (import/copybara) and internal review. The MacOS CPU failed build will not block merge (since it is unrelated)

@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Nov 23, 2020
@copybara-service copybara-service bot merged commit 91f2cca into tensorflow:master Nov 23, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@fchollet fchollet fchollet approved these changes

@gbaned gbaned Awaiting requested review from gbaned

Assignees

@gbaned gbaned

Labels
cla: yes comp:keras Keras related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gonnet @mihaimaruseac @fchollet @kokoro-team @gbaned