Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable use of <ctime> with micro_time with -DTF_LITE_USE_CTIME #44634

Merged
merged 1 commit into from Nov 11, 2020

Conversation

advaitjain
Copy link
Member

@advaitjain advaitjain commented Nov 5, 2020

This change:

  • uses a based micro_time implementation by default for ohost-builds (previously needed TAGS=posix)
  • sets -DTF_LITE_USE_CTIME in the target makefiles for cross-compilation (instead of having to specialize micro_time.cc in the target folder).

Tested that we see the benchmark timing with the following commands:

Linux:

make -f tensorflow/lite/micro/tools/make/Makefile -j8 test_keyword_benchmark

Output:

InitializeKeywordRunner() took 35 ticks (0 ms)
KeywordRunNIerations(1) took 22 ticks (0 ms)
KeywordRunNIerations(10) took 136 ticks (0 ms)

Linux + xtensa_hifimini

make -f tensorflow/lite/micro/tools/make/Makefile -j8 TARGET=xtensa_hifimini OPTIMIZED_KERNEL_DIR=xtensa_hifimini XTENSA_CORE=mini1m1m_RG test_keyword_benchmark

Output:

InitializeKeywordRunner() took 1389000 ticks (1389 ms)
KeywordRunNIerations(1) took 89318 ticks (89 ms)
KeywordRunNIerations(10) took 892739 ticks (892 ms)

Linux + hexagon: untested

Fixes: http://b/172372039

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Nov 5, 2020
@google-ml-butler
Copy link

Thanks for contributing to TensorFlow Lite Micro.

To keep this process moving along, we'd like to make sure that you have completed the items on this list:

We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review.

@google-cla google-cla bot added the cla: yes label Nov 5, 2020
@advaitjain advaitjain added the kokoro:force-run Tests on submitted change label Nov 5, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 5, 2020
@advaitjain advaitjain added the comp:micro Related to TensorFlow Lite Microcontrollers label Nov 5, 2020
@gbaned gbaned self-assigned this Nov 6, 2020
@gbaned gbaned added the comp:lite TF Lite related issues label Nov 6, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Nov 6, 2020
@advaitjain advaitjain added the kokoro:force-run Tests on submitted change label Nov 6, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 6, 2020
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Nov 10, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Nov 10, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 10, 2020
@advaitjain advaitjain added the kokoro:force-run Tests on submitted change label Nov 10, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 10, 2020
@advaitjain advaitjain added the kokoro:force-run Tests on submitted change label Nov 10, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 10, 2020
@copybara-service copybara-service bot merged commit 70e463a into tensorflow:master Nov 11, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Nov 11, 2020
@advaitjain advaitjain deleted the micro-time-on-x86 branch November 11, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:lite TF Lite related issues comp:micro Related to TensorFlow Lite Microcontrollers ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants