Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s390x support for compiler related TCs #45012

Merged

Conversation

skribm9
Copy link
Contributor

@skribm9 skribm9 commented Nov 19, 2020

Multiple compiler related test cases were failing with this error:
Internal: TargetRegistry::lookupTarget failed: No available targets are compatible with triple "x86_64-pc-linux"
The test cases were retrieving default value, "x86_64-pc-linux" as target architecture.

This PR adds support for s390x as target architecture and fixes 15 compiler related TCs on s390x.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Nov 19, 2020
@google-cla google-cla bot added the cla: yes label Nov 19, 2020
@gbaned gbaned self-assigned this Nov 19, 2020
@gbaned gbaned added the comp:xla XLA label Nov 19, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Nov 19, 2020
@gbaned gbaned requested a review from sanjoy November 19, 2020 15:13
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Nov 21, 2020
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Nov 21, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 21, 2020
@copybara-service copybara-service bot merged commit 1da597f into tensorflow:master Nov 23, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Nov 23, 2020
@skribm9 skribm9 deleted the s390x_compiler_fixes branch November 30, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:xla XLA ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants