Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --cpu=x64_arm64_windows as a compilation target on Windows #45151

Open
ianier opened this issue Nov 24, 2020 · 3 comments
Open

Allow --cpu=x64_arm64_windows as a compilation target on Windows #45151

ianier opened this issue Nov 24, 2020 · 3 comments
Labels
type:build/install Build and install issues type:feature Feature requests

Comments

@ianier
Copy link

ianier commented Nov 24, 2020

Compilation of TensorFlow on Windows currently assumes x64 as a target CPU architecture. Searching .bzl files for "x64_windows" shows the many places in TF where this assumption is made.

In principle, though, nothing should prevent compiling TensorFlow to target ARM64 on Windows (--cpu=x64_arm64_windows, see the bazel doc).

This feature request is about adding support for '--cpu=x64_arm64_windows' to produce ARM64 binaries. The goal is to be able to use TF on Windows on ARM 64 bits.

@ianier ianier added the type:feature Feature requests label Nov 24, 2020
@ravikyram ravikyram added the type:build/install Build and install issues label Nov 24, 2020
@ravikyram ravikyram assigned ymodak and unassigned ravikyram Nov 24, 2020
@ymodak ymodak added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Nov 25, 2020
@ymodak ymodak removed their assignment Nov 25, 2020
@mihaimaruseac
Copy link
Collaborator

Will happily review and approve a PR

@tensorflowbutler tensorflowbutler removed the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Dec 2, 2020
@ianier
Copy link
Author

ianier commented Dec 13, 2020

I would happily work on a PR, but unfortunately my knowledge of Bazel and TF build system is nearly zero. Passing --cpu=x64_arm64_windows causes the TF build system to download LLVM instead of using MSVC.
@mihaimaruseac : Can you hint where to start fixing/patching? The initial goal is to get the MSVC toolchain invoked, then I should be able to work on the required code changes.

@mihaimaruseac
Copy link
Collaborator

TF needs to download LLVM to build as it contains a lot of code that uses LLV libraries directly (MLIR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:build/install Build and install issues type:feature Feature requests
Projects
None yet
Development

No branches or pull requests

5 participants