Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for gpu platforms other than CUDA in jax #45344

Merged
merged 4 commits into from Dec 3, 2020
Merged

Allow for gpu platforms other than CUDA in jax #45344

merged 4 commits into from Dec 3, 2020

Conversation

inailuig
Copy link
Contributor

@inailuig inailuig commented Dec 2, 2020

This is a prerequisite in order to start building jax with suport for AMD gpus (ROCm).

(The accompanying changes for jax can be found here: https://github.com/inailuig/jax/tree/rocm; I will open a PR there once this gets accepted)

Also see google/jax#2012

@hawkinsp

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Dec 2, 2020
@google-cla google-cla bot added the cla: yes label Dec 2, 2020
@hawkinsp hawkinsp requested review from hawkinsp and removed request for joker-eph December 2, 2020 17:39
@inailuig
Copy link
Contributor Author

inailuig commented Dec 2, 2020

This discussion is probably also relevant: #30381 (comment)

Copy link
Contributor

@hawkinsp hawkinsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

tensorflow/compiler/xla/pjrt/gpu_device.cc Show resolved Hide resolved
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Dec 2, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 2, 2020
@hawkinsp hawkinsp added the kokoro:force-run Tests on submitted change label Dec 2, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 2, 2020
@gbaned gbaned self-assigned this Dec 3, 2020
@gbaned gbaned added the comp:xla XLA label Dec 3, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Dec 3, 2020
@hawkinsp hawkinsp added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Dec 3, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 3, 2020
@hawkinsp
Copy link
Contributor

hawkinsp commented Dec 3, 2020

I'm trying to force this through our CI system. If you wouldn't mind, I think it might go through if you would push another change to this PR (e.g., anything; improve a comment or something like that).

@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Dec 3, 2020
@hawkinsp hawkinsp added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Dec 3, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 3, 2020
@copybara-service copybara-service bot merged commit 719fe24 into tensorflow:master Dec 3, 2020
PR Queue automation moved this from Assigned Reviewer to Merged Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:xla XLA ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants