New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to switch to h5py 3.1.0 #45380
Try to switch to h5py 3.1.0 #45380
Conversation
This is the new strings r/w behavior for 3.x series: https://docs.h5py.org/en/latest/strings.html |
Just to reference the original ticket #44467 |
Remove other encoder decode
In the CI logs I see different unicode issues related to https://docs.h5py.org/en/latest/strings.html#what-about-numpy-s-u-type
But CPU tests don't fail locally inside the official TF devel image It is hard to work locally where official devel images are not aligned with the CI. I think that probably this is caused unaligned |
I've tried to use So I've just reverted on one of the first commit to let you see that Linux is passing but not Win/Mac |
@mihaimaruseac What was the Win and OSX issue? |
Windows seems to be broken at HEAD due to an MLIR integrate from 12 hours ago. MacOS seemed to pass. Probably the environment is different? Hopefully there is no rollback. |
PiperOrigin-RevId: 346215317 Change-Id: Id990b67a0e3c446555b590c0711159bd3ab88465
@mihaimaruseac Can you reopen this? Do you have Shell access on a win/MacOS machine? |
I cannot reopen, GitHub does not let me :( I can get access to a windows machine, but it will take a while as I have a few P0 items to finish this week/early next week. |
This reverts commit d36db29.
Yes I know it is merged but I meant something like #45487 |
No description provided.