micro: list test and kernel files explicitly in Makefile #45389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TensorFlow Lite Micro. To keep this process moving along, we'd like to make sure that you have completed the items on this list:
We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review. |
In the micro Makefile, trivially move MICROLITE_BENCHMARK_SRCS def out from in between test and kernel defs in preperation for the next change, which will be more readable if the test and kernel defs are together.
List test and kernel files explicitly to provide an easy means of excluding files from the build that would have matched the now-removed wildcard patterns. Listing exceptions and using $(filter-out) would have been more ugly and prone to merge conflicts. These lists were verified to match those produced by the wildcards they replaced as of commit 5543ed6. There are a few other wildcards in the Makefile for files other than kernels and kernel tests. Those aren't replaced in this commit, but should probably be replaced eventually for consistency's sake.
rkuester
force-pushed
the
feature-micro-exclude-kernels-list
branch
from
d43ca6a
to
cd67a17
Compare
rkuester
changed the title
This was referenced Dec 4, 2020
advaitjain
approved these changes
Dec 4, 2020
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #45387. We occasionally want to exclude, from the build, test and kernel files that would otherwise match wildcards.
Listing files explicitly, as done in this PR, is one method of achieving the goal. There is an alternative PR #45388 which keeps the wildcards and adds exclusion lists instead. This PR's scheme may be a little cleaner and less prone to merge conflicts when multiple PRs with exclusions are in-flight at the same time. Of course, the tradeoff is a long list of files; however, that's a common trend in build system configuration files these days.