-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tflite: Add casts to std::min/std::max when comparing mis-matched types #45486
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
d27931f
to
36e125e
Compare
@abattery Ready for re-review |
On some targets, such as the STM32L4, type deduction fails for calls to
std::min
&std::max
when comparing values with mis-matched types:quantization_util.cpp:293:79: error: no matching function for call to 'min(double, float)'
quantization_util.cpp:293:79: note: deduced conflicting types for parameter 'const _Tp' ('double' and 'float')
This PR fixes this compilation error by casting
<double>
or<float>
respectively to these type mis-matchedstd::min
/std::max
calls.