Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activation, kernel, bias are all attributes in Dense #45640

Merged
merged 2 commits into from Mar 12, 2021
Merged

activation, kernel, bias are all attributes in Dense #45640

merged 2 commits into from Mar 12, 2021

Conversation

gqqnbig
Copy link
Contributor

@gqqnbig gqqnbig commented Dec 13, 2020

Current documentation only says Dense implements such math operation. It's unclear to user how to access kernel and bias.

It turns out, through reading the code, these are all attributes added in this layer.

kernel and bias are added in build(), while activation is added in the constructor.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Dec 13, 2020
@google-cla google-cla bot added the cla: yes label Dec 13, 2020
@gbaned gbaned self-assigned this Dec 14, 2020
@gbaned gbaned added the comp:keras Keras related issues label Dec 14, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Dec 14, 2020
@gbaned gbaned self-requested a review December 14, 2020 08:29
fchollet
fchollet reviewed Dec 17, 2020
View reviewed changes
tensorflow/python/keras/layers/core.py Outdated
@@ -1085,7 +1085,8 @@ class Dense(Layer):
where `activation` is the element-wise activation function
passed as the `activation` argument, `kernel` is a weights matrix
created by the layer, and `bias` is a bias vector created by the layer
(only applicable if `use_bias` is `True`).
(only applicable if `use_bias` is `True`). These are all attributes in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of

@gqqnbig
Copy link
Contributor Author

gqqnbig commented Dec 17, 2020

@fchollet fixed

@gbaned gbaned requested a review from fchollet December 21, 2020 13:33
@gbaned gbaned added the awaiting review Pull request awaiting review label Dec 21, 2020
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 11, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 11, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 11, 2021
@copybara-service copybara-service bot merged commit 02718a3 into tensorflow:master Mar 12, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Mar 12, 2021
@gqqnbig gqqnbig deleted the gqqnbig-patch-2 branch March 12, 2021 02:55
@gbaned gbaned removed the awaiting review Pull request awaiting review label Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

@gbaned gbaned Awaiting requested review from gbaned

Assignees

@gbaned gbaned

Labels
cla: yes comp:keras Keras related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gqqnbig @fchollet @kokoro-team @gbaned