Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to ensure that files in tensorflow/lite/micro have proper license and formatting #45674

Merged
merged 18 commits into from Dec 15, 2020
Merged

Add check to ensure that files in tensorflow/lite/micro have proper license and formatting #45674

merged 18 commits into from Dec 15, 2020

Conversation

advaitjain
Copy link
Member

@advaitjain advaitjain commented Dec 14, 2020 •
edited

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Dec 14, 2020
@google-ml-butler
Copy link

Thanks for contributing to TensorFlow Lite Micro.

To keep this process moving along, we'd like to make sure that you have completed the items on this list:

We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review.

@google-cla google-cla bot added the cla: yes label Dec 14, 2020
@advaitjain advaitjain added kokoro:force-run Tests on submitted change comp:micro Related to TensorFlow Lite Microcontrollers labels Dec 14, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 14, 2020
@advaitjain advaitjain added the kokoro:force-run Tests on submitted change label Dec 14, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 14, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Dec 14, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 14, 2020
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Dec 14, 2020
@advaitjain advaitjain added the ready to pull PR ready for merge process label Dec 14, 2020
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Dec 15, 2020
@advaitjain advaitjain changed the title Add check to ensure that files in tensorflow/lite/micro have proper license. Add check to ensure that files in tensorflow/lite/micro have proper license and formatting Dec 15, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Dec 15, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 15, 2020
@gbaned gbaned self-assigned this Dec 15, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Dec 15, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 15, 2020
@advaitjain advaitjain added the ready to pull PR ready for merge process label Dec 15, 2020
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Dec 15, 2020
@advaitjain advaitjain added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Dec 15, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 15, 2020
@advaitjain
Manually ignore some sections of the code.
646b965 
Currently we do not control the exact version of clang-format. In
particular, the version on the docker image is old (clang-format-7).

The current discrepancy is small but we can revisit later if this
becomes a problem.
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Dec 15, 2020
@advaitjain advaitjain added the kokoro:force-run Tests on submitted change label Dec 15, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 15, 2020
@advaitjain advaitjain added the ready to pull PR ready for merge process label Dec 15, 2020
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Dec 15, 2020
@advaitjain advaitjain added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Dec 15, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 15, 2020
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Dec 15, 2020
@advaitjain advaitjain added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Dec 15, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 15, 2020
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Dec 15, 2020
@advaitjain advaitjain added the kokoro:force-run Tests on submitted change label Dec 15, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 15, 2020
@advaitjain advaitjain added the ready to pull PR ready for merge process label Dec 15, 2020
@copybara-service copybara-service bot merged commit 8e65c84 into tensorflow:master Dec 15, 2020
PR Queue automation moved this from Assigned Reviewer to Merged Dec 15, 2020
@advaitjain advaitjain deleted the license-check branch December 16, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njeffrie njeffrie njeffrie approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:micro Related to TensorFlow Lite Microcontrollers ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@advaitjain @njeffrie @kokoro-team @gbaned