Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bazel build with -DTF_LITE_STATIC_MEMORY. #45679

Merged
merged 1 commit into from Dec 15, 2020

Conversation

advaitjain
Copy link
Member

@advaitjain advaitjain commented Dec 15, 2020

Tested that the following command passes:

bazel test tensorflow/lite/micro/...  --test_tag_filters=-no_oss --build_tag_filters=-no_oss --copt=-DTF_LITE_STATIC_MEMORY

This PR was created to address http://b/175642155 and #45535 (comment)

In reality, while there is a mismatch between the internal and external CI (which should indeed be addressed), that wasn't the source of the problem. See #45535 (comment) for more information.

Tested that the following command passes:
```
bazel test tensorflow/lite/micro/...  --test_tag_filters=-no_oss --build_tag_filters=-no_oss --copt=-DTF_LITE_STATIC_MEMORY
```

Addresses http://b/175642155
@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Dec 15, 2020
@google-ml-butler
Copy link

Thanks for contributing to TensorFlow Lite Micro.

To keep this process moving along, we'd like to make sure that you have completed the items on this list:

We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review.

@advaitjain advaitjain added the comp:micro Related to TensorFlow Lite Microcontrollers label Dec 15, 2020
@google-cla google-cla bot added the cla: yes label Dec 15, 2020
@advaitjain advaitjain added the kokoro:force-run Tests on submitted change label Dec 15, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 15, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Dec 15, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 15, 2020
Copy link
Contributor

@njeffrie njeffrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why does moving this fix the build?

@advaitjain advaitjain added the kokoro:force-run Tests on submitted change label Dec 15, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 15, 2020
@gbaned gbaned self-assigned this Dec 15, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Dec 15, 2020
@advaitjain advaitjain added the kokoro:force-run Tests on submitted change label Dec 15, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 15, 2020
@copybara-service copybara-service bot merged commit 8b85309 into tensorflow:master Dec 15, 2020
PR Queue automation moved this from Assigned Reviewer to Merged Dec 15, 2020
@advaitjain advaitjain deleted the bazel-static-memory branch December 15, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:micro Related to TensorFlow Lite Microcontrollers ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants