Update the external license check to be close to the internal check. #45799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually updated the licenses in the files that are not excluded from a license check in the internal CI system, and removed these exclusions in the external CI system as well. The external exclusions that are not excluded internally are: * .bzl * .h5 * .tpl * .properties Will will fix these remaining discrepancies incrementally, as and when a PR touches such a file and runs afoul of the internal checks. See http://b/175315163#comment7 for more details.
|
Thanks for contributing to TensorFlow Lite Micro. To keep this process moving along, we'd like to make sure that you have completed the items on this list:
We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review. |
njeffrie
approved these changes
Dec 17, 2020
google-ml-butler
bot
added
kokoro:force-run
…cense-exclusions Manually fixed these conflicts: tensorflow/lite/micro/testing/test_bluepill_binary.sh
advaitjain
added
kokoro:force-run
advaitjain
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually updated the licenses in the files that are not excluded from a license check in the internal CI system, and removed these exclusions in the external CI system as well.
The remaining external exclusions that are not excluded internally are:
Will will fix these remaining discrepancies incrementally, as and when a PR touches such a file and runs afoul of the internal checks.
See http://b/175315163#comment7 for more details.