Extract a function for parsing op DEPTH_TO_SPACE #46026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract the parsing of op parameters from the flatbuffer out of a switch statement case, into a standalone function which can be called by the micro op resolver.
petewarden
requested review from
petewarden
and removed request for
advaitjain
petewarden
approved these changes
Dec 30, 2020
google-ml-butler
bot
added
kokoro:force-run
advaitjain
requested changes
Dec 30, 2020
| @@ -1059,7 +1059,7 @@ TfLiteStatus ParseDepthToSpace(const Operator* op, | |||
| if (schema_params != nullptr) { | |||
| params->block_size = schema_params->block_size(); | |||
| } else { | |||
| // TODO(b/157480169): We should either return kTfLiteError or fill in some | |||
| // old todo (b/157480169): We should either return kTfLiteError or fill in some | |||
There was a problem hiding this comment.
we do want to keep this TODO as is. If it is triggering some failure in the CI then we'll need to fix the CI. Can you please change it back to TODO(b/): and then I'll take a look at what the CI error is.
advaitjain
approved these changes
Jan 2, 2021
google-ml-butler
bot
added
kokoro:force-run
|
All checks are passing. Merging a PR needs two approvals from a Googler so we'll need to wait until @petewarden can approve the change in the internal review system before this can be merged. |
Merge branch 'master' of https://github.com/tensorflow/tensorflow into feature-micro-add-op-depth-to-space-pr1
petewarden
approved these changes
Jan 11, 2021
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
|
@advaitjain not sure what internal check this one is failing. |
|
The failing tests are internal, unrelated and currently flaky. I have set the internal change to submit while ignoring these tests. This PR should get merged shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the parsing of op parameters from the flatbuffer out of a
switch statement case, into a standalone function which can be
called by the micro op resolver.
This PR is part of the work to port operator DEPTH_TO_SPACE
from lite to micro, as tracked in issue #46025.