Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose class_id parameter on subclasses of SensitivitySpecificityBase #46099

Merged
merged 1 commit into from Mar 18, 2021

Conversation

dwyatte
Copy link
Contributor

@dwyatte dwyatte commented Dec 31, 2020

This PR addresses #46017 by simply exposing the class_id parameter on all subclasses of SensitivitySpecificityBase.

I've added tests to confirm this works on 3-way multi-label data and also added a guard for a test from tensorflow/python/keras:metrics_confusion_matrix_test that wasn't working locally due to requiring scipy (seems this pattern is used elsewhere in the codebase for running tests locally).

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Dec 31, 2020
@google-cla google-cla bot added the cla: yes label Dec 31, 2020
@gbaned gbaned self-assigned this Jan 1, 2021
@gbaned gbaned added the comp:keras Keras related issues label Jan 1, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jan 1, 2021
@gbaned gbaned self-requested a review January 1, 2021 02:06
@gbaned gbaned added the awaiting review Pull request awaiting review label Jan 5, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 11, 2021
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 11, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 11, 2021
@gbaned gbaned removed the awaiting review Pull request awaiting review label Mar 12, 2021
@copybara-service copybara-service bot merged commit b7908a0 into tensorflow:master Mar 18, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:keras Keras related issues ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants