Add target and pass_string parameters to the renode test script to fix #46186 #46187
Conversation
…tensorflow#46186 This allows the `test_with_renode.sh` script to be called via the makefile with all the parameters needed to run on a given target, while also staying consistent with the other test scripts. As a result of this change, the makefile is passing in the following parameters to the test scripts: #1 - test binary path tensorflow#2 - string to determine that test passes tensorflow#3 - target Parameter tensorflow#3 is only used for `test_with_renode.sh` Manually tested that the following commands now pass: ``` make -f tensorflow/lite/micro/tools/make/Makefile TARGET=bluepill test_kernel_add_test make -f tensorflow/lite/micro/tools/make/Makefile TARGET=stm32f4 TAGS=cmsis-nn test_kernel_fully_connected_test ```
|
Thanks for contributing to TensorFlow Lite Micro. To keep this process moving along, we'd like to make sure that you have completed the items on this list:
We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review. |
| @@ -479,7 +479,7 @@ $(1): $$($(1)_BINARY) | |||
| $(1)_bin: $$($(1)_BINARY).bin | |||
| test_$(1): $$($(1)_BINARY) | |||
| @test -f $$(TEST_SCRIPT) || (echo 'Unable to find the test script. Is the software emulation available in $$(TARGET)?'; exit 1) | |||
| $$(TEST_SCRIPT) $$($(1)_BINARY) '~~~ALL TESTS PASSED~~~' | |||
| $$(TEST_SCRIPT) $$($(1)_BINARY) $$(TEST_PASS_STRING) $$(TARGET) | |||
There was a problem hiding this comment.
Looks like we're weren't passing TARGET in before. I'm confused how this worked previously.
There was a problem hiding this comment.
It worked for everything but running tests with renode (which is the only place where we need TARGET.
Even with renode, it works when we call make test which is what is part of our CI since that uses a different test rule which does pass in the target:
This common code in helper_functions.inc is only used when we do:
make -f tensorflow/lite/micro/tools/make/Makefile TARGET=bluepill test_kernel_add_test
which is what this change is fixing.
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
This allows the
test_with_renode.shscript to be called via the makefile with all the parameters needed to run on a given target, while also staying consistent with the other test scripts.As a result of this change, the makefile is passing in the following parameters to the test scripts:
param 1 - test binary path
param 2 - string to determine that test passes
param 3 - target
Parameter 3 is only used for
test_with_renode.shManually tested that the following commands now pass:
Fixes #46186