New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ReshapeSparseTensor into a template+class #46275
Refactor ReshapeSparseTensor into a template+class #46275
Conversation
- This is in preparation for adding a GPU implementation. - No functional change.
@allenlavoie Any idea who should review this? |
@penpornk has been working on sparse kernels I believe. Penporn, want to take a look? |
@allenlavoie @cheshire Sure, I can review this. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR and I'm so sorry for the delay! I have minor comments.
- Remove unused context parameter. - Rename functor::ReshapeSparseTensor to functor::ReshapeSparseTensorFunctor. - Make integer constants const.
Gentle ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry again for the delay!
This is in preparation for adding a GPU implementation.
No functional change.
cc @nluehr