Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTEL MKL] DNN 0.x final code cleanup #46370

Merged
merged 1 commit into from Feb 24, 2021
Merged

[INTEL MKL] DNN 0.x final code cleanup #46370

merged 1 commit into from Feb 24, 2021

Conversation

gzmkl
Copy link
Contributor

@gzmkl gzmkl commented Jan 12, 2021

This final DNN 0.x code cleanup removes the header file which defines MACRO's that are not usable any more

  1. delete util/mkl_types.h
  2. update util/mkl_util.h, to un-include mkl_types.h
  3. update util/BUILD

It also addresses previous merge problems (code cleanup was accidently overwritten, or somehow missed). with the following source files:

  1. kernels/mkl/mkl_matmul_ops_common.h
  2. kernels/mkl/mkl_dequantize_op_test.cc
  3. util/mkl_util_test.cc

@gzmkl gzmkl requested a review from penpornk as a code owner January 12, 2021 17:33
@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Jan 12, 2021
@google-cla google-cla bot added the cla: yes label Jan 12, 2021
@gbaned gbaned self-assigned this Jan 13, 2021
@gbaned gbaned added the comp:mkl MKL related issues label Jan 13, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jan 13, 2021
@gbaned gbaned added the awaiting review Pull request awaiting review label Jan 20, 2021
@gzmkl
Copy link
Contributor Author

gzmkl commented Feb 23, 2021

I would appreciate that you can review and approve this PR, as it is the final one for DNN 0.x code cleanup and touch quite a few common files (MKL related). Thanks!

penpornk
penpornk approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so sorry for the delay and thank you for the PR! Hooray for the final clean-up! :)

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 23, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Feb 23, 2021
@penpornk penpornk removed the awaiting review Pull request awaiting review label Feb 23, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 23, 2021
@gbaned gbaned removed the ready to pull PR ready for merge process label Feb 24, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 24, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 24, 2021
@copybara-service copybara-service bot merged commit 089d2e1 into tensorflow:master Feb 24, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Feb 24, 2021
@gzmkl
Copy link
Contributor Author

gzmkl commented Feb 24, 2021

I'm so sorry for the delay and thank you for the PR! Hooray for the final clean-up! :)

Thank you!

@gzmkl gzmkl mentioned this pull request Feb 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penpornk penpornk penpornk approved these changes

@gbaned gbaned gbaned approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:mkl MKL related issues ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gzmkl @penpornk @gbaned @kokoro-team