Go: Deallocate large TF_TString on Tensor finalization #46541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankchn
approved these changes
Mar 2, 2021
google-ml-butler
bot
added
kokoro:force-run
rthadur
removed
awaiting review
rthadur
approved these changes
Mar 3, 2021
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 2.4 Tensorflow moved to the new way to store string tensors.
Earlier
std::stringwas used an array of strings was encoded as an array of 8-byte offsets followed by string data. With the current design of thetensorflow::tstringcreating tensor withNewTensorfunction could allocate string in two ways (description of the tstring types):TF_TSTR_SMALL- the contents of strings less than 22-bytes are stored in the TF_TString structTF_TSTR_LARGE- Heap allocated stringThe second case assumes that, in addition to TF_DeleteTensor, the string should be deallocated with TF_TString_Dealloc. This situation wasn't handled in the Go bindings.