Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uint32 and uint64 support for PopulationCount #46716

Conversation

yongtang
Copy link
Member

PopulationCount is part of the bitwise operations (BitwiseAnd/Or/Xor/etc)
though unlike other bitwise operatios, PopulationCount does not
have uint32 and uint64 support.

This PR add uint32 and uint64 support and fixes #46676.

Signed-off-by: Yong Tang yong.tang.github@outlook.com

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Jan 27, 2021
@google-cla google-cla bot added the cla: yes label Jan 27, 2021
@gbaned gbaned self-assigned this Jan 27, 2021
@gbaned gbaned added the comp:core issues related to core part of tensorflow label Jan 27, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jan 27, 2021
@gbaned gbaned added the prtype:bugfix PR to fix a bug label Jan 27, 2021
PopulationCount is part of the bitwise operations (BitwiseAnd/Or/Xor/etc)
though unlike other bitwise operatios, PopulationCount does not
have uint32 and uint64 support.

This PR add uint32 and uint64 support and fixes 46676.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@yongtang yongtang force-pushed the 46676-PopulationCount-uint32-uint64 branch from 85bc356 to 0118cff Compare January 27, 2021 17:02
@yongtang yongtang added the kokoro:force-run Tests on submitted change label Jan 27, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 27, 2021
@gbaned gbaned added the awaiting review Pull request awaiting review label Feb 5, 2021
@gbaned gbaned requested a review from hyeygit February 16, 2021 16:23
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Feb 22, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 22, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 22, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Feb 23, 2021
@copybara-service copybara-service bot merged commit 5b49cfe into tensorflow:master Feb 23, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Feb 23, 2021
@yongtang yongtang deleted the 46676-PopulationCount-uint32-uint64 branch February 23, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:core issues related to core part of tensorflow prtype:bugfix PR to fix a bug ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

tf.raw_ops.PopulationCount for uint32 not supported but documented
4 participants