Add relevant shape check for tf.reshape to prevent crash #46717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongtang
force-pushed
the
46693-reshape-validation
branch
from
2093bb2
to
d8f90e5
Compare
gbaned
added
comp:core
allenlavoie
approved these changes
Feb 22, 2021
tensorflow/core/kernels/reshape_op.h
Outdated
| } | ||
| return errors::InvalidArgument("Shape [", msg, | ||
| "] has too many elements"); | ||
| } |
There was a problem hiding this comment.
The indentation here looks wrong; might be a spaces (the rest of the file) vs. tabs issue?
google-ml-butler
bot
added
kokoro:force-run
yongtang
force-pushed
the
46693-reshape-validation
branch
from
d8f90e5
to
7c30cad
Compare
|
Thanks @allenlavoie for the review. Indeed that was a tab issue. I have updated the PR and fixed it. Please take a look. |
google-ml-butler
bot
added
kokoro:force-run
gbaned
removed
awaiting review
gbaned
approved these changes
Feb 24, 2021
google-ml-butler
bot
added
kokoro:force-run
|
The merge isn't working because we have some presubmits which run the test in a 1.x-style Graph+Session. Can you please decorate the test method with "@test_util.run_v2_only"? |
This PR tries to address the issue raised in 46693 where a shape with large number of elements will cause the tf.reshape to crash. This PR adds relevant shape check so that error message can be returned gracefully. This PR fixes 46693 Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang
force-pushed
the
46693-reshape-validation
branch
from
7c30cad
to
a41733a
Compare
allenlavoie
approved these changes
Mar 1, 2021
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address the issue raised in #46693 where
a shape with large number of elements will cause the
tf.reshape to crash.
This PR adds relevant shape check so that error message can
be returned gracefully.
This PR fixes #46693
This PR also fixes #46699
Signed-off-by: Yong Tang yong.tang.github@outlook.com