Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve rendering for tf.distribute.cluster_resolver.TPUClusterResolver in tpu_strategy API docs #46747

Merged
merged 3 commits into from Feb 9, 2021
Merged

Improve rendering for tf.distribute.cluster_resolver.TPUClusterResolver in tpu_strategy API docs #46747

merged 3 commits into from Feb 9, 2021

Conversation

8bitmp3
Copy link
Contributor

@8bitmp3 8bitmp3 commented Jan 28, 2021

This should fix the auto-linking and rendering

image

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jan 28, 2021
@google-cla google-cla bot added the cla: yes label Jan 28, 2021
@gbaned gbaned self-assigned this Jan 28, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jan 28, 2021
@gbaned gbaned requested a review from rxsang January 28, 2021 02:32
rxsang
rxsang approved these changes Jan 28, 2021
View reviewed changes
tensorflow/python/distribute/tpu_strategy.py Outdated
@@ -320,7 +320,7 @@ def __init__(self,
"""Synchronous training in TPU donuts or Pods.

Args:
tpu_cluster_resolver: A tf.distribute.cluster_resolver.TPUClusterResolver,
tpu_cluster_resolver: A `tf.distribute.cluster_resolver.TPUClusterResolver`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tf.distribute.cluster_resolver.TPUClusterResolver instance,

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jan 28, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 28, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 28, 2021
@gbaned gbaned removed the ready to pull PR ready for merge process label Jan 28, 2021
@gbaned gbaned requested a review from rxsang January 29, 2021 14:20
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 29, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 29, 2021
@gbaned gbaned added the kokoro:force-run Tests on submitted change label Jan 30, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 30, 2021
@gbaned
Copy link
Contributor

gbaned commented Jan 30, 2021

@8bitmp3 Can you please address Ubuntu Sanity errors? Thanks!

@gbaned gbaned added stat:awaiting response Status - Awaiting response from author and removed ready to pull PR ready for merge process labels Jan 30, 2021
@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Feb 5, 2021

@8bitmp3 Can you please address Ubuntu Sanity errors? Thanks!

thanks @gbaned exited with error code 1 - do you have an idea what it means? @rxsang

@rxsang
Copy link
Member

rxsang commented Feb 6, 2021

Ubuntu Sanity errors? Thanks!

thanks

I don't think that's relevant, maybe a transient issue?

@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Feb 7, 2021

Ubuntu Sanity errors? Thanks!

thanks

I don't think that's relevant, maybe a transient issue?

@gbaned @rxsang I think I found it in the logs: 2. do_pylint: Python 3 pylint FAIL

@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Feb 7, 2021

@gbaned @rxsang OK, PTAL, thank you

@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Feb 7, 2021
@google-ml-butler google-ml-butler bot added the ready to pull PR ready for merge process label Feb 7, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 7, 2021
@gbaned gbaned removed stat:awaiting response Status - Awaiting response from author ready to pull PR ready for merge process labels Feb 8, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 9, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 9, 2021
@copybara-service copybara-service bot merged commit 9829af6 into tensorflow:master Feb 9, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Feb 9, 2021
@8bitmp3 8bitmp3 deleted the patch-1 branch February 18, 2021 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxsang rxsang rxsang approved these changes

@gbaned gbaned gbaned approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@8bitmp3 @gbaned @rxsang @kokoro-team