Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose TString related C API #46803 #46804

Merged
merged 9 commits into from Mar 23, 2021
Merged

Expose TString related C API #46803 #46804

merged 9 commits into from Mar 23, 2021

Conversation

Oceania2018
Copy link
Contributor

No description provided.

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Jan 30, 2021
@google-cla google-cla bot added the cla: yes label Jan 30, 2021
@gbaned gbaned self-assigned this Jan 30, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jan 30, 2021
@gbaned gbaned requested a review from annarev January 30, 2021 13:23
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 1, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Feb 1, 2021
@mihaimaruseac mihaimaruseac removed the request for review from annarev February 1, 2021 16:37
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 1, 2021
@gbaned gbaned added the kokoro:force-run Tests on submitted change label Feb 2, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 2, 2021
@gbaned
Copy link
Contributor

gbaned commented Feb 2, 2021

@Oceania2018 Can you please address Ubuntu Sanity errors? Thanks!

@gbaned gbaned removed the ready to pull PR ready for merge process label Feb 2, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 2, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 2, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Feb 2, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 2, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 2, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Feb 2, 2021
@Oceania2018
Copy link
Contributor Author

Hi @mihaimaruseac, when whill this PR be merged?

@mihaimaruseac
Copy link
Collaborator

This fails to build internally and needs manual import and fixing.

Sadly, I cannot do this at this time, busy with other things. Will likely be able to next week

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 9, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 9, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Feb 11, 2021
@Oceania2018
Copy link
Contributor Author

Oceania2018 commented Feb 23, 2021 •
edited

@mihaimaruseac Do you have a chance to merge it?

@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Mar 1, 2021
@Oceania2018
Copy link
Contributor Author

@mihaimaruseac Sorry to bother you again, May I know when this PR will be merged? This is changes will fix the TString API for other languages binding like TensorFlow .NET since tensorflow v2.4 made a breaking change for string api.

@mihaimaruseac
Copy link
Collaborator

Hi.

Apologies for the delay. Been quite busy with the upcoming release and didn't get a chance to look into this.

Should be merged tomorrow.

@copybara-service copybara-service bot merged commit 82c4ebc into tensorflow:master Mar 23, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Mar 23, 2021
wxinix
wxinix reviewed Mar 24, 2021
View reviewed changes
Copy link
Contributor

@wxinix wxinix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tf_tstring.cc won't need this line: #include "tensorflow/c/tf_tensor.h"?

@adamcrume adamcrume mentioned this pull request Jun 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxinix wxinix wxinix left review comments

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Oceania2018 @gbaned @mihaimaruseac @wxinix @kokoro-team