[TFL] Fix unbounded activation clip range. #46991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For floating point with unbounded activation such as relu and none, set max/min to positive/negative infinity in case infinity is clipped. The change only affects floating point as std::numeric_limits<T>::has_infinity is always false for non-floating point.
abattery
reviewed
Feb 8, 2021
abattery
approved these changes
Feb 8, 2021
google-ml-butler
bot
added
kokoro:force-run
abattery
approved these changes
Feb 8, 2021
google-ml-butler
bot
added
kokoro:force-run
thaink
approved these changes
Feb 8, 2021
rthadur
added
ready to pull
abattery
reviewed
Feb 8, 2021
abattery
approved these changes
Feb 9, 2021
google-ml-butler
bot
added
kokoro:force-run
thaink
reviewed
Feb 9, 2021
miaout17
approved these changes
Feb 9, 2021
thaink
approved these changes
Feb 9, 2021
|
This PR will be hold until we can invest to make a thorough investigation about how current ops are handling inf value to ensure there is no compatibility issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45312. For floating point with unbounded activation such as relu and none, set max/min to positive/negative infinity in case infinity is clipped. The change only affects floating point as
std::numeric_limits<T>::has_infinityis always false for non-floating point. Doingmin(max(x, -inf), inf)is safe because positive infinity is larger than all values except itself and NaN and negative infinity is smaller than all values expect itself and NaN. With the change, TFLite is the same with TF for relu and none activation when input is positive or negative infinity.https://www.gnu.org/software/libc/manual/html_node/Infinity-and-NaN.html
https://en.cppreference.com/w/cpp/types/numeric_limits/has_infinity