Simplify tf.keras.activations.softmax codepath #47012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vodiylik
approved these changes
Feb 12, 2021
google-ml-butler
bot
added
kokoro:force-run
qlzh727
reviewed
Mar 1, 2021
| @@ -31,10 +31,10 @@ | |||
| from tensorflow.python.platform import test | |||
|
|
|||
|
|
|||
| def _ref_softmax(values): | |||
| m = np.max(values) | |||
| def _ref_softmax(values, axis=-1): | |||
There was a problem hiding this comment.
I think you can skip axis since its never changed by the caller.
There was a problem hiding this comment.
Sure let me modify it real quick.
qlzh727
approved these changes
Mar 1, 2021
google-ml-butler
bot
added
kokoro:force-run
qlzh727
approved these changes
Mar 3, 2021
google-ml-butler
bot
added
kokoro:force-run
gbaned
approved these changes
Mar 5, 2021
google-ml-butler
bot
added
kokoro:force-run
|
Hum, it seems that this PR gets rolled back since it breaks one of the internal test. Let me take a look and fix forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35199 although TFLite has already optimized that pattern into single softmax op. Since
tf.nn.softmaxsupports input of any rank, there is no reason to have other implementations. For common 3D input withaxis=-1,tf.nn.softmaxis also faster than original implementation.https://colab.research.google.com/drive/1E1rS69LJ7e-pH4bcyfxEJ_wC6IiRISvS?usp=sharing