Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated implementation of keras.backend.ndim #47014

Merged
merged 1 commit into from Feb 10, 2021
Merged

Remove duplicated implementation of keras.backend.ndim #47014

merged 1 commit into from Feb 10, 2021

Conversation

lgeiger
Copy link
Contributor

@lgeiger lgeiger commented Feb 8, 2021

This PR simplifies keras.backend.ndim by reusing the identical implementation from TensorShape.rank:

tensorflow/tensorflow/python/framework/tensor_shape.py

Lines 825 to 830 in 7516f6e

@property
def rank(self):
"""Returns the rank of this shape, or None if it is unspecified."""
if self._dims is not None:
return len(self._dims)
return None

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Feb 8, 2021
@google-cla google-cla bot added the cla: yes label Feb 8, 2021
@gbaned gbaned self-assigned this Feb 9, 2021
@gbaned gbaned added the comp:keras Keras related issues label Feb 9, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Feb 9, 2021
@gbaned gbaned self-requested a review February 9, 2021 04:36
qlzh727
qlzh727 approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@qlzh727 qlzh727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM.

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Feb 9, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 9, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 9, 2021
@copybara-service copybara-service bot merged commit f12d10a into tensorflow:master Feb 10, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Feb 10, 2021
@lgeiger lgeiger deleted the simplify-keras-ndims branch February 10, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qlzh727 qlzh727 qlzh727 approved these changes

@gbaned gbaned Awaiting requested review from gbaned

Assignees

@gbaned gbaned

Labels
cla: yes comp:keras Keras related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lgeiger @qlzh727 @kokoro-team @gbaned