Remove the sources containing the models from the TFLM static lib. #47018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TensorFlow Lite Micro. To keep this process moving along, we'd like to make sure that you have completed the items on this list:
We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review. |
These sources are only needed for specific tests and are now explicitly specified as part of creating a test target. From this change onwards, we will explicitly create test targets for tests that depend on sources outside of libtensorflow-microlite.a. This avoids putting unnecessary files into MICROLITE_CC_SRCS. Manually verified that the following command does not error out: ``` make -f tensorflow/lite/micro/tools/make/Makefile generate_keyword_benchmark_make_project && cd tensorflow/lite/micro/tools/make/gen/linux_x86_64_default/prj/keyword_benchmark/make/ && make -j8 ``` Fixes tensorflow#46860
advaitjain
force-pushed
the
remove-models-from-tflm-lib
branch
from
ef9a446
to
ba4a1db
Compare
yair-ehrenwald
approved these changes
Feb 9, 2021
There was a problem hiding this comment.
This is a much better way of doing things, makes a lot more sense than linking in the model data for every build when it is only needed for a specific test.
Also appreciate the added comments to the Makefile. Anything that makes that thing more understandable... :)
google-ml-butler
bot
added
kokoro:force-run
njeffrie
approved these changes
Feb 9, 2021
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These sources are only needed for specific tests and are now explicitly specified as part of creating a test target.
From this change onwards, we will explicitly create test targets for tests that depend on sources outside of libtensorflow-microlite.a. This avoids putting unnecessary files into MICROLITE_CC_SRCS.
Manually verified that the following command does not error out:
Fixes #46860