Add an InitializeTarget function that can be specialized for a given target. #47077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TensorFlow Lite Micro. To keep this process moving along, we'd like to make sure that you have completed the items on this list:
We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review. |
advaitjain
added
comp:micro
mansnils
reviewed
Feb 11, 2021
tensorflow/lite/micro/system_setup.h
Outdated
| namespace tflite { | ||
|
|
||
| // This should called during initialization of TFLM binaries and tests. It can | ||
| // be specialized if there us a need for custom target-specific intialization. |
advaitjain
force-pushed
the
system-setup-hook
branch
from
57a6974
to
dcd8bd6
Compare
advaitjain
changed the title
advaitjain
force-pushed
the
system-setup-hook
branch
from
dcd8bd6
to
99b240e
Compare
advaitjain
added
kokoro:force-run
advaitjain
force-pushed
the
system-setup-hook
branch
from
99b240e
to
f01253a
Compare
|
@njeffrie: after our dicussion, I decided to go one step further and not add calls to InitializeTarget from DebugLog for the Arduino and SparkfunEdge. Instead, I added a call to InitializeTarget from all of our examples. I like this approach more because it gives full control of the initialization to the application rather than having some mysterious init calls hidden away in DebugLog. The down-side is that I might have broken some examples on Arduino/SparkfunEdge because the change is not tested on actual hardware. |
advaitjain
force-pushed
the
system-setup-hook
branch
from
f01253a
to
a8cc378
Compare
advaitjain
added
ready to pull
…target. This will allow the unit tests to be run on additional targets that need some addiitonal initialization (for example cornstone_300 from tensorflow#46830). This particular change is broken out from the Cornstone PR tensorflow#46830 to be able to have smaller more reviewable PRs. In the past, we have added state to the DebugLog() and GetCurrentTimeTicks() functions as a way to avoid having an InitializeTarget function. With this change, we are deciding to go with an explicit intitialization step instead. This change has added calls to tflite::InitializeTarget to the tests, benchmarks, and examples and converted the Arduino and SparkfunEdge to make use of this explicit initialization. The changes for the Arduino and SparkfunEdge have not been tested on actual hardware. Progress towards tensorflow#46829
advaitjain
force-pushed
the
system-setup-hook
branch
from
a8cc378
to
81d33f1
Compare
advaitjain
added
kokoro:force-run
njeffrie
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the unit tests to be run on additional targets that need some addiitonal initialization (for example corstone_300 from #46830).
This particular change is broken out from the Corstone PR #46830 to be able to have smaller more reviewable PRs.
In the past, we have added state to the DebugLog() and GetCurrentTimeTicks() functions as a way to avoid having an InitializeTarget function. With this change, we are deciding to go with an explicit intitialization step instead.
This change has added calls to tflite::InitializeTarget to the tests, benchmarks, and examples and converted the Arduino and SparkfunEdge to make use of this explicit initialization.
The changes for the Arduino and SparkfunEdge have not been tested on actual hardware.
Progress towards #46829
Fixes http://b/150808076