Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where reordering tf.Transpose is not done correctly #47084

Merged
merged 1 commit into from Mar 2, 2021

Conversation

scottcjt
Copy link
Contributor

When reordering tf.Transpose (downwards) and the original transpose must be preserved, the insertion point is off-by-one.

As demonstrated in attached test, this scenario is not handled properly:

%0 = transpose(%input, %axis_t)
%1 = pad(%0, %axis_p)
return %0, %1

Will get operand #0 does not dominate this use error from IR verifier, indicating a value is used before its def.

cc: @huangkang-chn

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Feb 11, 2021
@google-cla google-cla bot added the cla: yes label Feb 11, 2021
@gbaned gbaned self-assigned this Feb 11, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Feb 11, 2021
@gbaned gbaned added the awaiting review Pull request awaiting review label Feb 17, 2021
@gbaned gbaned requested a review from smit-hinsu March 1, 2021 18:07
Copy link
Contributor

@smit-hinsu smit-hinsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix along with a test!

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 1, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 1, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 1, 2021
@copybara-service copybara-service bot merged commit f01e77f into tensorflow:master Mar 2, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review Pull request awaiting review cla: yes ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants