Fix for keras applications preprocess_input with data_format="channels_first" symbolic tensors #47135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tensors The scaling by std deviation was not taking into account the channel order and caused an error when a symbolic tensor was provided with mode='torch' (e.g. for tf.keras.applications.densenet.preprocess_input). This commit corrects that, and runs the tests for all modes instead of just the default.
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46539
The rescaling by
stdin keras.applications.imagenet_utils._preprocess_symbolic_input was not taking into accountdata_format, causing a shape mismatch error.This was not caught by the unit tests as only the default
mode='caffe'was tested, which does not usestd. I changed the test to run for all modes.