Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for how to add new optimized kernels to TFLM. #47227

Merged
merged 1 commit into from Feb 18, 2021
Merged

Documentation for how to add new optimized kernels to TFLM. #47227

merged 1 commit into from Feb 18, 2021

Conversation

advaitjain
Copy link
Member

No description provided.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Feb 17, 2021
@google-ml-butler
Copy link

Thanks for contributing to TensorFlow Lite Micro.

To keep this process moving along, we'd like to make sure that you have completed the items on this list:

We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review.

@google-cla google-cla bot added the cla: yes label Feb 17, 2021
@advaitjain advaitjain force-pushed the opt-kernel-doc branch 2 times, most recently from da74b52 to 816a1cb Compare February 17, 2021 22:55
@advaitjain advaitjain added the comp:micro Related to TensorFlow Lite Microcontrollers label Feb 17, 2021
njeffrie
njeffrie approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@njeffrie njeffrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording nit, otherwise looks good.

tensorflow/lite/micro/docs/optimized_kernel_implementations.md Outdated

# Software Architecture

We recommend viewing the optimized kernel architecture as composed of the following three modules:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The optimized kernel architecture is composed of the following three modules:" Feels a bit clearer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 17, 2021
@kokoro-team kokoro-team removed kokoro:force-run Tests on submitted change labels Feb 17, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Feb 17, 2021
@advaitjain advaitjain added the kokoro:force-run Tests on submitted change label Feb 17, 2021
@kokoro-team kokoro-team removed kokoro:force-run Tests on submitted change labels Feb 17, 2021
@advaitjain advaitjain added ready to pull PR ready for merge process kokoro:force-run Tests on submitted change and removed ready to pull PR ready for merge process labels Feb 17, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 18, 2021
@gbaned gbaned self-assigned this Feb 18, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Feb 18, 2021
@copybara-service copybara-service bot merged commit 498026c into tensorflow:master Feb 18, 2021
PR Queue automation moved this from Assigned Reviewer to Merged Feb 18, 2021
@advaitjain advaitjain deleted the opt-kernel-doc branch February 18, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njeffrie njeffrie njeffrie approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:micro Related to TensorFlow Lite Microcontrollers ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@advaitjain @njeffrie @kokoro-team @gbaned