New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tf.data] refactor serialization tests based on CheckpointTestBase in kernel_tests #47318
[tf.data] refactor serialization tests based on CheckpointTestBase in kernel_tests #47318
Conversation
...ata/experimental/kernel_tests/serialization/assert_cardinality_dataset_serialization_test.py
Outdated
Show resolved
Hide resolved
@jsimsa I tried to run the serialization tests once before refactoring them with When I run the following,
I get
Is there any issue with the current test targets or am I missing something? UPDATE: The tests are being filtered out even after the changes. |
You see the tests not being executed because they are all marked as "no_oss" (e.g. https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/data/experimental/kernel_tests/serialization/BUILD#L39). If you remove the tag, the test should execute. |
@kvignesh1420 can you please check sanity build failures ? |
@rthadur I have fixed the ci sanity issues. |
@kvignesh1420 there are internal projects that import the serialization module this PR moves and I will need to address the conflicts before your PR is merged, I hope to take care of that today |
Thanks @jsimsa |
This PR is a pre-requisite for #47314 where serializability tests are being cleaned up and moved to
kernel_tests
.DatasetSerializationTestBase
toCheckpointTestBase
to be consistent with the future test cases.checkpoint_test_base
target.cc: @jsimsa