Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Windows debug build #47351

Merged
merged 1 commit into from Feb 26, 2021

Conversation

jgehw
Copy link
Contributor

@jgehw jgehw commented Feb 23, 2021

PDB file format has internal 32-bit limits, which doesn't allow PDB files to grow beyond 4GB even on x64 builds

thus use reduced debug symbols set in order not to exceed 4GB limit

PDB file format has internal 32-bit limits, which don't allow PDB files to grow beyond 4GB even on x64 builds
thus use reduce debug symbols set in order not to exceed 4GB limit
@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Feb 23, 2021
@google-cla google-cla bot added the cla: yes label Feb 23, 2021
@gbaned gbaned self-assigned this Feb 24, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Feb 24, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Feb 25, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 25, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 25, 2021
@rthadur rthadur added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Feb 25, 2021
@copybara-service copybara-service bot merged commit ac271da into tensorflow:master Feb 26, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Feb 26, 2021
@jgehw jgehw deleted the fix-windows-debug-build branch March 2, 2021 18:42
jgehw added a commit to jgehw/tensorflow that referenced this pull request Sep 13, 2021
jgehw added a commit to jgehw/tensorflow that referenced this pull request Sep 14, 2021
jgehw added a commit to jgehw/tensorflow that referenced this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

5 participants