Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TFLM github CI bazel build #47377

Merged
merged 1 commit into from Feb 24, 2021

Conversation

advaitjain
Copy link
Member

To keep the bazel build short, we maintain a copy of the subset of packages that are needed for the TFLM (+ shared TfLite) bazel targets.

Eigen was updated for TF with 0effd3d and we make the corresponding change in TFLM's pared down version of workspace.bzl with this change.

To keep the bazel build short, we maintain a copy of the subset of
packages that are needed for the TFLM (+ shared TfLite) bazel targets.

Eigen was updated for TF with 0effd3d
and we make the corresponding change in TFLM's pared down version of
workspace.bzl with this change.
@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Feb 24, 2021
@google-ml-butler
Copy link

Thanks for contributing to TensorFlow Lite Micro.

To keep this process moving along, we'd like to make sure that you have completed the items on this list:

We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review.

@google-cla google-cla bot added the cla: yes label Feb 24, 2021
@advaitjain advaitjain added comp:micro Related to TensorFlow Lite Microcontrollers kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 24, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 24, 2021
@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Feb 24, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 24, 2021
@njeffrie
Copy link
Contributor

Will we to have to continue updating these packages manually?

@advaitjain
Copy link
Member Author

Will we to have to continue updating these packages manually?

yes, for now. It just so happened that my enabling bazel for TFLM github CI coincided with changes and updates to eigen. Things had been quite stable for a while.

@copybara-service copybara-service bot merged commit 28f1284 into tensorflow:master Feb 24, 2021
@advaitjain advaitjain deleted the fix-tflm-build branch February 24, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:micro Related to TensorFlow Lite Microcontrollers ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants