Remove unnecessary model parsing from keras.model.load_model #47435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monicadsong
approved these changes
Mar 11, 2021
google-ml-butler
bot
added
kokoro:force-run
rthadur
added
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes duplicated SavedModel parsing from
keras.model.load_model. The result of parsing was never used and it is also not needed for error handling either since the same function will be called at the start ofsaved_model_load.load:tensorflow/tensorflow/python/keras/saving/saved_model/load.py
Line 124 in 7e1c942
This removes the need to read the file content and parse the saved model twice which can improve performance when loading models from a remote file system like GCS.