[Grappler] Add dataset.shard(1, 0) to noop_elimination pass #47499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsimsa
reviewed
Mar 3, 2021
| @@ -43,6 +43,23 @@ NodeDef *MakeUnaryNode(StringPiece node_type, int count, string input_node, | |||
| GetCommonAttributes(), graph); | |||
| } | |||
|
|
|||
| NodeDef *MakeShardNode(int count, string input_node, MutableGraphView *graph) { | |||
There was a problem hiding this comment.
Instead of introducing MakeShardNode, generalize MakeUnaryNode to take a list of integers (as opposed to a single integer).
jsimsa
reviewed
Mar 3, 2021
| @@ -51,6 +68,23 @@ NodeDef *MakeUnaryNonConstNode(StringPiece node_type, string input_node, | |||
| GetCommonAttributes(), graph); | |||
| } | |||
|
|
|||
| NodeDef *MakeShardNonConstNode(string input_node, MutableGraphView *graph) { | |||
There was a problem hiding this comment.
Instead of introducing MakeShardNonConstNode, generalize MakeNonConstNode to take a list of DTYPES to use to create placeholders.
jsimsa
requested changes
Mar 3, 2021
tensorflowbutler
removed
the
stat:awaiting response
jsimsa
approved these changes
Apr 5, 2021
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your time on reviewing this PR. There are some addition to the test as
ShardDatasetis not a unary dataset op.