Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Github #47520 Step number of batch_steps_per_second #47521

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Fixes Github #47520 Step number of batch_steps_per_second #47521

merged 1 commit into from
Apr 8, 2021

Conversation

brychcy
Copy link
Contributor

@brychcy brychcy commented Mar 3, 2021

No description provided.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Mar 3, 2021
@google-cla google-cla bot added the cla: yes label Mar 3, 2021
@brychcy brychcy mentioned this pull request Mar 3, 2021
Closed
@rthadur rthadur requested a review from rchao March 3, 2021 15:31
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Mar 3, 2021
@amahendrakar amahendrakar linked an issue Mar 3, 2021 that may be closed by this pull request
TensorBoard callback: step is always 0 for batch_steps_per_second #47520
Closed
@gbaned gbaned removed the request for review from rchao March 19, 2021 18:07
@gbaned gbaned added the comp:keras Keras related issues label Mar 19, 2021
@gbaned gbaned self-requested a review March 19, 2021 18:07
@gbaned gbaned added the awaiting review Pull request awaiting review label Mar 19, 2021
fchollet
fchollet approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 25, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 25, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 25, 2021
@rthadur rthadur added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Mar 25, 2021
@gbaned gbaned removed the awaiting review Pull request awaiting review label Mar 26, 2021
@gbaned
Copy link
Contributor

gbaned commented Mar 26, 2021

@brychcy Can you please address Ubuntu Sanity errors? Thanks!

@gbaned gbaned removed the ready to pull PR ready for merge process label Mar 26, 2021
@brychcy
Copy link
Contributor Author

brychcy commented Mar 26, 2021

@brychcy Can you please address Ubuntu Sanity errors? Thanks!

I'll have a look.

Problem is:

Found 1 non-allowlisted pylint errors:
tensorflow/python/keras/callbacks.py:2448: [C0301(line-too-long), ] Line too long (97/80)`

@brychcy
Copy link
Contributor Author

brychcy commented Mar 26, 2021

@gbaned, Fix is pushed.
I guess I cannot retrigger those checks myself, right?

@gbaned gbaned requested a review from fchollet March 27, 2021 03:30
@gbaned gbaned added the awaiting review Pull request awaiting review label Mar 30, 2021
@brychcy
Copy link
Contributor Author

brychcy commented Apr 1, 2021

@gbaned, my updated patch just added a linebreak to the patch already approved by @fchollet.
do you really think he needs to approve it again?

@gbaned
Copy link
Contributor

gbaned commented Apr 1, 2021

@gbaned, my updated patch just added a linebreak to the patch already approved by @fchollet.
do you really think he needs to approve it again?

@brychcy There are commits after approved by @fchollet. Hence it requires approval again. Thanks!

fchollet
fchollet approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 8, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 8, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Apr 8, 2021
@copybara-service copybara-service bot merged commit 1ddf969 into tensorflow:master Apr 8, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

@gbaned gbaned Awaiting requested review from gbaned

Assignees

@gbaned gbaned

Labels
cla: yes comp:keras Keras related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TensorBoard callback: step is always 0 for batch_steps_per_second
5 participants
@brychcy @gbaned @fchollet @kokoro-team @rthadur