Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for bucket_by_sequence_length api. #47541

Merged
merged 3 commits into from Mar 5, 2021
Merged

Update docs for bucket_by_sequence_length api. #47541

merged 3 commits into from Mar 5, 2021

Conversation

PratsBhatt
Copy link
Contributor

Added more examples for bucket_by_sequence_length API. Explained the pitfall of using the option pad_to_buckt_boundary option.

This pull request is for the issue: #47513

@PratsBhatt
Update grouping.py
ea94749 
Add example for bucket_by_sequence_length.
@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Mar 3, 2021
@google-cla google-cla bot added the cla: yes label Mar 3, 2021
@PratsBhatt PratsBhatt changed the title Update grouping.py Update docs for but_by_sequence_length api. Mar 3, 2021
@PratsBhatt PratsBhatt changed the title Update docs for but_by_sequence_length api. Update docs for bucket_by_sequence_length api. Mar 3, 2021
@rthadur rthadur requested review from rxsang and jsimsa March 4, 2021 00:49
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Mar 4, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 4, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 4, 2021
@gbaned gbaned self-assigned this Mar 4, 2021
@gbaned gbaned added the comp:data tf.data related issues label Mar 4, 2021
@PratsBhatt
Update grouping.py
a6e1464 
Add input data as it creates a conflict.
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Mar 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 4, 2021
@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Mar 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 4, 2021
@PratsBhatt
Update grouping.py
04659f6 
Fix pylint issues.
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Mar 4, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 4, 2021
@PratsBhatt
Copy link
Contributor Author

Could someone guide me, why the check related to copybara is failing? I tried to understand, but when I am trying to open it, it says the page is not reachable.

Any help will be appreciated. Thank you in advance.

@copybara-service copybara-service bot merged commit d8d85aa into tensorflow:master Mar 5, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsimsa jsimsa jsimsa approved these changes

@rthadur rthadur rthadur approved these changes

@rxsang rxsang Awaiting requested review from rxsang

Assignees

@rthadur rthadur

@gbaned gbaned

Labels
cla: yes comp:data tf.data related issues ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PratsBhatt @jsimsa @rthadur @kokoro-team @gbaned