Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not specialize eigen convolution classes for ppc64le arch #47768

Merged
merged 1 commit into from Mar 16, 2021

Conversation

maxiwell
Copy link
Contributor

@maxiwell maxiwell commented Mar 12, 2021

Eigen merged a new ppc64le improvement that specializes the
Eigen::internal::gemm_pack_rhs structure. TF also specializes the
packing routine. This patch removes this double specialization for
ppc64le, using only the Eigen one.


This change is Reviewable

Eigen merged a new ppc64le improvement that specializes the
Eigen::internal::gemm_pack_rhs structure. TF also specializes the
packing routine. This patch removes this double specialization for
ppc64le, using only the Eigen one.
@maxiwell
Copy link
Contributor Author

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 12, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 12, 2021
@gbaned gbaned self-assigned this Mar 14, 2021
@gbaned gbaned added the comp:core issues related to core part of tensorflow label Mar 14, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Mar 14, 2021
@maxiwell maxiwell requested a review from ezhulenev March 16, 2021 14:32
@maxiwell
Copy link
Contributor Author

maxiwell commented Mar 16, 2021

Is this import/copybara error an important thing?

EDIT: import/copybara check has passed now (I didn't change anything)

@copybara-service copybara-service bot merged commit 80adc81 into tensorflow:master Mar 16, 2021
PR Queue automation moved this from Assigned Reviewer to Merged Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:core issues related to core part of tensorflow ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants