modernize Python in losses.py and its tests #47873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeb02
reviewed
Mar 19, 2021
There was a problem hiding this comment.
Thank you for the change. Some of the changes affect compatibility with Python 2.x, which was a constraint on us at some point. We'll double check if that is still the case or if we can go ahead apply these changes.
Aside from that, many of the changes in this PR, are stylistic and indentation changes. Please refrain from doing that unless there is a compelling reason.
mihaimaruseac
approved these changes
Mar 23, 2021
google-ml-butler
bot
added
kokoro:force-run
|
@zenogantner Can you please check @mihaimaruseac's comments and keep us posted ? Thanks! |
|
@zenogantner Can you please resolve conflicts? Thanks! |
mihaimaruseac
approved these changes
Mar 26, 2021
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
object.super()calls.futureimports.six..format()with f-strings.