New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pluggable Device] Add custom device mem allocator for Pluggable device. #47921

Merged

copybara-service merged 3 commits into tensorflow:master from kulinseth:pluggable_device_mem_allocator

Mar 22, 2021

Contributor

kulinseth commented Mar 19, 2021 •

edited

The commit provides a simple alternative to BFCAllocator for Pluggable devices
to do their own device memory management.

@penpornk , @annarev , @jzhoulon


          [Pluggable Device] Add custom device mem allocator for Pluggable devi…

8df007c

…ces.

The commit provides a simple alternative to BFCAllocator for Pluggable devices
to do their own device memory management.

google-ml-butler bot added the size:M label

google-cla bot added the cla: yes label

penpornk self-requested a review

March 19, 2021 16:43

penpornk requested changes

View reviewed changes

Member

penpornk left a comment •

edited

Thank you very much for the PR! I think you forgot to add pluggable_device_simple_allocator.cc and pluggable_device_simple_allocator.h?


          Adding the missing files.

95ea566

Contributor Author

kulinseth commented Mar 19, 2021

Thank you very much for the PR! I think you forgot to add pluggable_device_simple_allocator.cc and pluggable_device_simple_allocator.h?

Ah, thanks!. Added it.

gbaned self-assigned this

gbaned added this to Assigned Reviewer in PR Queue via automation


          Using the CPlatform to provide the UseBfcAllocator flag.

8ebbb5a

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer

penpornk approved these changes

View reviewed changes

Member

penpornk left a comment

Thank you for the changes!

google-ml-butler bot added kokoro:force-run ready to pull labels

kokoro-team removed the kokoro:force-run label

Contributor

rthadur commented Mar 19, 2021

@kulinseth can you please check sanity build failures ?

Member

penpornk commented Mar 19, 2021

@rthadur They are minor formatting errors. In the interest of time (since the branch cut is next week), I'll just manually import the PR and fix them. :) I'm just waiting for the oneDNN and Windows Bazel GPU CI builds to finish.

Contributor Author

kulinseth commented Mar 20, 2021

Thanks a lot @penpornk. Please let me know if there is needed form my side.

copybara-service bot merged commit 8fac95d into tensorflow:master

PR Queue automation moved this from Approved by Reviewer to Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment