Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Recording memory APIs in the benchmark. #47948

Merged

Conversation

advaitjain
Copy link
Member

This allows us to see how the memory usage is affected with different kernel implementations.

Debugging http://b/183232978

This allows us to see how the memory usage is affected with different
kernel implementations.

Debugging http://b/183232978
@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Mar 20, 2021
@google-ml-butler
Copy link

Thanks for contributing to TensorFlow Lite Micro.

To keep this process moving along, we'd like to make sure that you have completed the items on this list:

We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review.

@google-cla google-cla bot added the cla: yes label Mar 20, 2021
@advaitjain advaitjain requested review from nkreeger and removed request for njeffrie March 20, 2021 17:27
@advaitjain advaitjain added the comp:micro Related to TensorFlow Lite Microcontrollers label Mar 20, 2021
@gbaned gbaned self-assigned this Mar 21, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Mar 21, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 22, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 22, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 22, 2021
Copy link
Contributor

@njeffrie njeffrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we need to include the recording allocator in the BUILD file for the benchmarks.

@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Mar 22, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 22, 2021
@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Mar 23, 2021
@kokoro-team kokoro-team removed kokoro:force-run Tests on submitted change labels Mar 23, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Mar 23, 2021
@advaitjain advaitjain added the kokoro:force-run Tests on submitted change label Mar 23, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 23, 2021
@advaitjain advaitjain added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 23, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 23, 2021
@advaitjain
Copy link
Member Author

looks like we need to include the recording allocator in the BUILD file for the benchmarks.

fixed.

@gbaned gbaned requested a review from nkreeger March 24, 2021 14:23
@gbaned gbaned added awaiting review Pull request awaiting review and removed ready to pull PR ready for merge process labels Mar 31, 2021
@advaitjain advaitjain added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 15, 2021
@copybara-service copybara-service bot merged commit fd9a78f into tensorflow:master Apr 15, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Apr 15, 2021
@gbaned gbaned removed the awaiting review Pull request awaiting review label Apr 15, 2021
@advaitjain advaitjain deleted the benchmark-recording-api branch April 15, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:micro Related to TensorFlow Lite Microcontrollers kokoro:force-run Tests on submitted change ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

5 participants