[ROCm] Fix for ROCM CSB breakage - 210322 #47980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheshire
approved these changes
Mar 24, 2021
google-ml-butler
bot
added
kokoro:force-run
|
@deven-amd Can you please check build failures. Thanks! |
|
@gbaned all the build error point to don't think they are related to the change in this PR. can you trigger the tests again...maybe whatever was causing them, has been fixed. |
deven-amd
force-pushed
the
google_upstream_rocm_csb_fix_210322
branch
from
11e2175
to
f06a8e1
Compare
|
@gbaned , rebased my branch to resolve the merge conflict |
deven-amd
referenced
this pull request
Mar 25, 2021
Doing this to make the ROCm build green. PiperOrigin-RevId: 364982542 Change-Id: Idf5f94fbcbebf0b6d1da6d468905b86385fb2392
|
@gbaned , rebased (again) my branch to resolve the merge conflict |
deven-amd
force-pushed
the
google_upstream_rocm_csb_fix_210322
branch
from
f06a8e1
to
2d96b80
Compare
deven-amd
force-pushed
the
google_upstream_rocm_csb_fix_210322
branch
from
2d96b80
to
6441d6b
Compare
deven-amd
force-pushed
the
google_upstream_rocm_csb_fix_210322
branch
from
6441d6b
to
df0dc4a
Compare
chsigg
approved these changes
Apr 6, 2021
google-ml-butler
bot
added
kokoro:force-run
|
@deven-amd can you please resolve conflicts |
The following commit adds GPU support for int32/int64 support for the Unique/UniqueWithCounts ops, but breaks ROCm build in the process tensorflow@02585ac ``` tensorflow/core/kernels/unique_op_gpu.cu.cc:292:9: error: no matching constructor for initialization of 'gpuprim::TransformInputIterator<int, SegmentIndicatorFunctor<unsigned long, int>, gpuprim::CountingInputIterator<int>>' (aka 'transform_iterator<rocprim::counting_iterator<int, long>, tensorflow::(anonymous namespace)::SegmentIndicatorFunctor<unsigned long, int>, int>') segment_indicator_iter(0, {sorted_input_ptr}); ^ ~~~~~~~~~~~~~~~~~~~~~ tensorflow/core/kernels/unique_op_gpu.cu.cc:176:12: note: in instantiation of member function 'tensorflow::UniqueOpGPU<unsigned long, int>::ComputeAsync' requested here explicit UniqueOpGPU(OpKernelConstruction* context) ^ tensorflow/core/kernels/unique_op_gpu.cu.cc:461:27: note: in instantiation of member function 'tensorflow::UniqueOpGPU<unsigned long, int>::UniqueOpGPU' requested here TF_CALL_REAL_NUMBER_TYPES(REGISTER_UNIQUE_GPU); ``` This PR/commit disables ROCm support for newly added ops to get the CSB passing again. We are looking into resolving the build errors, and will file a separate PR to re-enable ROCm functionality for the same. This PR commit also adds the `no_rocm` tag to a couple of unit tests that start failing as a consequence of lack of ROCm support for these ops. ``` //tensorflow/python/keras/optimizer_v2:adamax_test_gpu FAILED in 3 out of 3 in 7.0s //tensorflow/python/training:adam_test_gpu FAILED in 3 out of 3 in 6.3s ```
…m platform tensorflow@50f8897 ``` //tensorflow/python/keras/distribute:dataset_creator_model_fit_test_gpu FAILED in 3 out of 3 in 112.5s ``` This commit adds a `no_rocm` tag to temporarily disable that unit-test on ROCm.
deven-amd
force-pushed
the
google_upstream_rocm_csb_fix_210322
branch
from
df0dc4a
to
43124b6
Compare
rthadur
approved these changes
Apr 6, 2021
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1
The following commit adds GPU support for int32/int64 support for the Unique/UniqueWithCounts ops, but breaks ROCm build in the process
02585ac
This PR/commit disables ROCm support for newly added ops to get the CSB passing again. We are looking into resolving the build errors, and will file a separate PR to re-enable ROCm functionality for the same. This PR commit also adds the
no_rocmtag to a couple of unit tests that start failing as a consequence of lack of ROCm support for these ops.2
The following commit adds a new unit-test which is failing on the ROCm platform
50f8897
This commit adds a
no_rocmtag to temporarily disable that unit-test on ROCm./cc @cheshire @chsigg