Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-TRT Fix batch dim for unit test with scalar input #47982

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented Mar 22, 2021

PR #40545 introduced tests with scalar input. For such input we should not access shape.dim_size(0). This PR fixes this error in the converter unit tests.

Tagging @bixia1 for review and @DEKHTIARJonathan for visibility.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Mar 22, 2021
@google-cla google-cla bot added the cla: yes label Mar 22, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 22, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 22, 2021
@gbaned gbaned self-assigned this Mar 23, 2021
@gbaned gbaned added the comp:gpu:tensorrt Issues specific to TensorRT label Mar 23, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Mar 23, 2021
@copybara-service copybara-service bot merged commit 0979d2a into tensorflow:master Mar 23, 2021
PR Queue automation moved this from Assigned Reviewer to Merged Mar 23, 2021
@tfeher tfeher deleted the trt_reshape_fix_scalar_batch_dim_test branch May 16, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:gpu:tensorrt Issues specific to TensorRT ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants