Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTEL MKL] Fix failing v1 CI test #47992

Conversation

gaurides
Copy link
Contributor

Added check for dtype as MklMatMul supports bfloat16 and float32. whereas the default type is float64. Now with this fix, the correct op names can be compared.

@gaurides gaurides requested a review from caisq as a code owner March 22, 2021 22:53
@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Mar 22, 2021
@google-cla google-cla bot added the cla: yes label Mar 22, 2021
@gbaned gbaned self-assigned this Mar 23, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Mar 23, 2021
@gbaned gbaned requested a review from penpornk April 8, 2021 18:09
@gbaned gbaned added the awaiting review Pull request awaiting review label Apr 8, 2021
@gbaned gbaned requested a review from allenlavoie April 30, 2021 14:09
@gbaned gbaned requested review from penpornk and removed request for penpornk May 10, 2021 10:44
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and sorry for the delay!

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels May 24, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer May 24, 2021
@penpornk penpornk removed the awaiting review Pull request awaiting review label May 24, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 24, 2021
@copybara-service copybara-service bot merged commit 2f8baa2 into tensorflow:master May 25, 2021
PR Queue automation moved this from Approved by Reviewer to Merged May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants