Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-TRT Prefer static shapes #48060

Merged
merged 1 commit into from Mar 26, 2021

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented Mar 24, 2021

This PR improves TF-TRT conversion when the "Optimal" profile generation strategy is used with only a single input shape.

In that case the TRT engine would have a single profile with min=opt=max. This means that the engine should only handle the concrete input dimension defined by the single profile. Therefore, we can define the TRT network with static shapes. This increases conversion rate, because some of our converters are not able to convert dynamic shape input.

This PR updates TRTEngineOp constructor to retrieve the profile_strategy graph attribute, and pass it to TrtShapeOptimizationProfiles during the InitProfiles call. Additionally an IsStaticCompatible method is introduced to TrtShapeOptimizationProfiles, and is used in TRTEngineOp::BuildEngine to decide whether to build a dynamic or a static engine.

Tracker #45481
Tagging @bixia1 for review and @DEKHTIARJonathan

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Mar 24, 2021
@google-cla google-cla bot added the cla: yes label Mar 24, 2021
@gbaned gbaned self-assigned this Mar 25, 2021
@gbaned gbaned added the comp:gpu:tensorrt Issues specific to TensorRT label Mar 25, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Mar 25, 2021
@tfeher
Copy link
Contributor Author

tfeher commented Mar 25, 2021

I have updated the lowercase name handling and fixed one error in trt_engine_op_test.

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 25, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 25, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 25, 2021
@copybara-service copybara-service bot merged commit 0907666 into tensorflow:master Mar 26, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:gpu:tensorrt Issues specific to TensorRT ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants