Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keras: Replace trivial control flow ops with tf.where #48337

Merged
merged 1 commit into from Apr 9, 2021
Merged

Keras: Replace trivial control flow ops with tf.where #48337

merged 1 commit into from Apr 9, 2021

Conversation

lgeiger
Copy link
Contributor

@lgeiger lgeiger commented Apr 6, 2021

This PR replaces the use of control flow ops in Keras with tf.where where using control flow is not needed.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Apr 6, 2021
@google-cla google-cla bot added the cla: yes label Apr 6, 2021
@gbaned gbaned self-assigned this Apr 7, 2021
@gbaned gbaned added the comp:keras Keras related issues label Apr 7, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 7, 2021
@gbaned gbaned self-requested a review April 7, 2021 07:22
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 8, 2021
qlzh727
qlzh727 approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@qlzh727 qlzh727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Looks good to me.

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 8, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 8, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Apr 9, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 9, 2021
@copybara-service copybara-service bot merged commit 108b794 into tensorflow:master Apr 9, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Apr 9, 2021
@lgeiger lgeiger deleted the keras-cond-where branch April 9, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qlzh727 qlzh727 qlzh727 approved these changes

@gbaned gbaned gbaned approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:keras Keras related issues kokoro:force-run Tests on submitted change ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lgeiger @qlzh727 @gbaned @kokoro-team