[r2.5 port][ROCm] Port PR 48336 to r2.5 #48495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default exact-match comparison errros on ROCm for the "acos" op due to mis-compares on one particular value after the 7th decimal value (for float32) and 16th decimal value (for float64). See below. ``` ... ... tensorflow/core/framework/tensor_testutil.cc:128: Failure Value of: IsEqual(Tx[i], Ty[i], t) Actual: false (0.044724799692630768 not equal to 0.044724646955728531) Expected: true i = 13 tensorflow/core/framework/tensor_testutil.cc:128: Failure Value of: IsEqual(Tx[i], Ty[i], t) Actual: false (0.044724799692630768 not equal to 0.044724646955728531) Expected: true i = 27 tensorflow/core/framework/tensor_testutil.cc:128: Failure Value of: IsEqual(Tx[i], Ty[i], t) Actual: false (0.044724799692630768 not equal to 0.044724646955728531) Expected: true i = 41 tensorflow/core/framework/tensor_testutil.cc:128: Failure Value of: IsEqual(Tx[i], Ty[i], t) Actual: false (0.044724799692630768 not equal to 0.044724646955728531) Expected: true i = 55 tensorflow/core/framework/tensor_testutil.cc:128: Failure Value of: IsEqual(Tx[i], Ty[i], t) Actual: false (0.044724799692630768 not equal to 0.044724646955728531) Expected: true i = 69 tensorflow/core/framework/tensor_testutil.cc:128: Failure Value of: IsEqual(Tx[i], Ty[i], t) Actual: false (0.044724799692630768 not equal to 0.044724646955728531) Expected: true i = 83 [ FAILED ] UnaryOpsTest.AcosDT_FLOATDT_FLOAT (5 ms) ... ... tensorflow/core/framework/tensor_testutil.cc:128: Failure Value of: IsEqual(Tx[i], Ty[i], t) Actual: false (0.044725087168733454 not equal to 0.044725087168733128) Expected: true i = 13 tensorflow/core/framework/tensor_testutil.cc:128: Failure Value of: IsEqual(Tx[i], Ty[i], t) Actual: false (0.044725087168733454 not equal to 0.044725087168733128) Expected: true i = 27 tensorflow/core/framework/tensor_testutil.cc:128: Failure Value of: IsEqual(Tx[i], Ty[i], t) Actual: false (0.044725087168733454 not equal to 0.044725087168733128) Expected: true i = 41 tensorflow/core/framework/tensor_testutil.cc:128: Failure Value of: IsEqual(Tx[i], Ty[i], t) Actual: false (0.044725087168733454 not equal to 0.044725087168733128) Expected: true i = 55 tensorflow/core/framework/tensor_testutil.cc:128: Failure Value of: IsEqual(Tx[i], Ty[i], t) Actual: false (0.044725087168733454 not equal to 0.044725087168733128) Expected: true i = 69 tensorflow/core/framework/tensor_testutil.cc:128: Failure Value of: IsEqual(Tx[i], Ty[i], t) Actual: false (0.044725087168733454 not equal to 0.044725087168733128) Expected: true i = 83 [ FAILED ] UnaryOpsTest.AcosDT_DOUBLEDT_DOUBLE (5 ms) ... ... ```
mihaimaruseac
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @mihaimaruseac @angerson
#48336