Fix all conv layers when filters is 0 #48566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fchollet can you review this ? |
fchollet
reviewed
Apr 19, 2021
bhack
approved these changes
Apr 19, 2021
google-ml-butler
bot
added
kokoro:force-run
rthadur
approved these changes
Apr 19, 2021
bhack
requested changes
Apr 20, 2021
| @@ -298,6 +303,11 @@ def test_conv2d_zero_kernel_size(self): | |||
| with self.assertRaises(ValueError): | |||
| keras.layers.Conv2D(**kwargs) | |||
|
|
|||
| def test_conv2d_zero_filters(self): | |||
| kwargs = {'filters': 0, 'kernel_size': 2} | |||
| with self.assertRaisesRegex(ValueError): | |||
There was a problem hiding this comment.
It has two params self.assertRaisesRegex(ValueError, <str>):
There was a problem hiding this comment.
@bhack sorry about that. I fixed it.
bhack
approved these changes
Apr 20, 2021
google-ml-butler
bot
added
kokoro:force-run
bhack
approved these changes
Apr 20, 2021
google-ml-butler
bot
added
kokoro:force-run
|
I guess I run into some pylint errors . Solved them. Please review @bhack |
bhack
approved these changes
Apr 20, 2021
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #48470. This PR raises a
ValueErrorfor all conv layers upon encounteringfilters = 0. @fchollet