Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make bazel build //tensorflow/tools/pip_package:build_pip_package work on Jetson devices #48588

Merged
merged 2 commits into from Apr 30, 2021
Merged

make bazel build //tensorflow/tools/pip_package:build_pip_package work on Jetson devices #48588

merged 2 commits into from Apr 30, 2021

Conversation

freedomtan
Copy link
Contributor

@freedomtan freedomtan commented Apr 17, 2021 •
edited by mihaimaruseac

Fixed two problems stopping bazel build //tensorflow/tools/pip_package:build_pip_package on Jetson devices

  1. CUDA 10.2 doesn't work well with absl CORD
  2. mlir needs AArch64 codegen

Fixes #48468

@freedomtan
CUDA 10.2 doesn't work well with CORD
e5b6829
@freedomtan
enable llvm::AArch64CodeGen
4933ada 
needed by mlir, e.g.,
`//tensorflow/compiler/mlir/tools/kernel_gen/tf_to_kernel`
@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Apr 17, 2021
@google-cla google-cla bot added the cla: yes label Apr 17, 2021
@freedomtan
Copy link
Contributor Author

freedomtan commented Apr 17, 2021 •
edited

The CUDA 10.2 problem is not device specific or aarch64 specific, see #48468

@freedomtan freedomtan closed this Apr 17, 2021
@freedomtan freedomtan reopened this Apr 17, 2021
@gbaned gbaned self-assigned this Apr 19, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 19, 2021
@gbaned gbaned added the comp:core issues related to core part of tensorflow label Apr 19, 2021
@gbaned gbaned added the awaiting review Pull request awaiting review label Apr 22, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 26, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 26, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 26, 2021
@rthadur rthadur added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Apr 26, 2021
@gbaned gbaned removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Apr 27, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 27, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 27, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Apr 28, 2021
@copybara-service copybara-service bot merged commit 1d8903e into tensorflow:master Apr 30, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@gbaned gbaned gbaned approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:core issues related to core part of tensorflow ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build bazel error
5 participants
@freedomtan @mihaimaruseac @gbaned @kokoro-team @rthadur