Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port RESIZE_BILINEAR kernel and tests from lite to micro #48617

Merged
merged 4 commits into from Apr 22, 2021
Merged

Port RESIZE_BILINEAR kernel and tests from lite to micro #48617

merged 4 commits into from Apr 22, 2021

Conversation

patriklaurell
Copy link
Contributor

@patriklaurell patriklaurell commented Apr 19, 2021 •
edited

This is PR three out of three in delivering #48537. This PR ports the resize_bilinear kernel and the corresponding tests to micro, as well as adds resize bilinear to the micro build. @advaitjain

@google-ml-butler google-ml-butler bot added the size:L CL Change Size: Large label Apr 19, 2021
@google-ml-butler
Copy link

Thanks for contributing to TensorFlow Lite Micro.

To keep this process moving along, we'd like to make sure that you have completed the items on this list:

We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review.

@google-cla google-cla bot added the cla: yes label Apr 19, 2021
@patriklaurell patriklaurell marked this pull request as draft April 19, 2021 16:36
@patriklaurell patriklaurell mentioned this pull request Apr 19, 2021
Closed
@gbaned gbaned self-assigned this Apr 20, 2021
@gbaned gbaned added the comp:micro Related to TensorFlow Lite Microcontrollers label Apr 20, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 20, 2021
@patriklaurell patriklaurell marked this pull request as ready for review April 20, 2021 08:07
@patriklaurell
Copy link
Contributor Author

@advaitjain now that #48616 is merged this is ready for review

@gbaned gbaned requested a review from advaitjain April 21, 2021 03:27
advaitjain
advaitjain requested changes Apr 21, 2021
View reviewed changes
Copy link
Member

@advaitjain advaitjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only small nit comments.

tensorflow/lite/micro/kernels/resize_bilinear.cc Outdated Show resolved Hide resolved
tensorflow/lite/micro/kernels/resize_bilinear.cc Outdated Show resolved Hide resolved
tensorflow/lite/micro/kernels/resize_bilinear_test.cc Outdated Show resolved Hide resolved
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Apr 21, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 21, 2021
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Apr 21, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 21, 2021
@copybara-service copybara-service bot merged commit 95c364c into tensorflow:master Apr 22, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Apr 22, 2021
@bhack bhack mentioned this pull request May 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@advaitjain advaitjain advaitjain approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:micro Related to TensorFlow Lite Microcontrollers ready to pull PR ready for merge process size:L CL Change Size: Large
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@patriklaurell @advaitjain @kokoro-team @gbaned